-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First attempt to update code for GTK4 #97
Draft
smartyg
wants to merge
51
commits into
nzjrs:master
Choose a base branch
from
smartyg:gtk4-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eatures used together
…e alpha field and mark the alpha property as deprecated. Conflicts: src/osm-gps-map-widget.c
…it matches the internal used type and is able to pass the alpha channel as wel
…signal; this removes critical error message: g_cclosure_marshal_VOID__VOID: assertion 'n_param_values == 1' failed
…ue)' failed; by changing to generic poiner type
…ODO: see if this can be enabled in GTK3
…re_single_get_current_button
…ot availible anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to update osm-gps-map to GTK4. So far I only updated the main code. I will try to update the examples in the coming days. Please note this branch is not finished/final yet, it is still work-in-progress. Also note this branch was made on top of my own master (which for example also includes #95). Once I feel comfortable enough, I will do a rebase of the GTK4 update based on the nzjrs/osm-gps-map/master branch.
Please feel free to test, review, suggest changes or give any other comments.
I hope any one is interested in this update.