Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 chore: update update-notifier to solve dependbot issue #270

Merged
merged 1 commit into from
Oct 28, 2022
Merged

🧹 chore: update update-notifier to solve dependbot issue #270

merged 1 commit into from
Oct 28, 2022

Conversation

KieraDOG
Copy link
Contributor

@KieraDOG KieraDOG commented Oct 25, 2022

fixes #269

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for jest-preview-library canceled.

Name Link
🔨 Latest commit 154c802
🔍 Latest deploy log https://app.netlify.com/sites/jest-preview-library/deploys/635c1005f001c3000920a48d

Copy link
Owner

@nvh95 nvh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KieraDOG,

Thanks for submitting this PR. There is an issue when upgrading update-notifier from version 5 to 6. That is jest-preview gets broken. You can try it yourself by executing:

pnpm run server

at the root of this monorepo.

The reason is that from version 6, update-notifier drops CommonJS (ESM only), while the current jest-preview CLI is pure CommonJS.

So, to fix this issue completely, we need to convert update-notifier to CommonJS, that might requires configuring Rollup.

Thank you very much for submitting this. I think I can take it from there then implementing the compilation.

Source: https://github.com/yeoman/update-notifier/releases/tag/v6.0.0
More context: #129 (comment)

@nvh95 nvh95 mentioned this pull request Oct 26, 2022
7 tasks
@nvh95 nvh95 merged commit 61108f1 into nvh95:main Oct 28, 2022
@nvh95
Copy link
Owner

nvh95 commented Oct 28, 2022

Hey @KieraDOG. Thanks for very much for your support. I will release it in 0.3.2 in a few days. But it's already ready in 0.3.2-alpha.1 by installing:

npm install --save-dev [email protected]
yarn add -D [email protected]
pnpm add -D [email protected]

@all-contributors please add @KieraDOG for code

@allcontributors
Copy link
Contributor

@nvh95

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @KieraDOG! 🎉

@15MariamS
Copy link

👋 Hi @nvh95, will v0.3.2 be released fully (out of alpha)? I'm also getting the mentioned dependabot alert in #269.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having dependabot alerts: Got allows a redirect to a UNIX socket
3 participants