Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Textmate: improvement on record entries and closure #169

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Textmate: improvement on record entries and closure #169

merged 5 commits into from
Dec 8, 2023

Conversation

glcraft
Copy link
Contributor

@glcraft glcraft commented Dec 8, 2023

  • Improvement on closure parameters parsing ({|...| })
  • Improvement on record entries (fields name) parsing (field:)

image

Known issue :
There are issues in interpolated strings if there is a quote following by a colon.

image

@fdncred
Copy link
Collaborator

fdncred commented Dec 8, 2023

I tested it. Seems good enough for now. Thank you again!

@fdncred fdncred merged commit 25e39a9 into nushell:main Dec 8, 2023
1 check passed
@fdncred fdncred mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glcraft @fdncred