Add OPL3_WriteRegDelayed() to buffer with a custom delay #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, OPL3_WriteRegBuffered() will delay any write by 2 (non-resampled) samples. It's possible that we might want to delay writes by some other (possibly variable) amount. OPL3_WriteRegDelayed() accepts an additional 'delay' argument, which contains the number of 49,716Hz samples to delay the write by.
sulix
added a commit
to sulix/omnispeak
that referenced
this pull request
Jan 26, 2023
Currently, we delay a few samples after every register write. This can be confusing, particularly with Nuked_OPL3, which also delays a couple of samples when OPL3_WriteRegBuffered() is used. It's also ugly to have to track all of the extra samples queued here and there. Make the number of delayed samples configurable with: sd_oplWriteDelay = <num> It's still based of the sample rate by default, otherwise put the number of samples you want, or 0 to disable it entirely. You can also disable/enable the OPL3_WriteRegBuffered() function with sd_nukedBufferWrites. By default, it's only enabled when sd_oplWriteDelay is nonzero. A PR to make NukedOPL3's buffering configurable exists here: nukeykt/Nuked-OPL3#27 Note that NukedOPL3's buffering is based in the 49716Hz samples, not the resampled values, like our sd_oplWriteDelay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, OPL3_WriteRegBuffered() will delay any write by 2 (non-resampled) samples. It's possible that we might want to delay writes by some other (possibly variable) amount.
OPL3_WriteRegDelayed() accepts an additional 'delay' argument, which contains the number of 49,716Hz samples to delay the write by.