-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: extend link checks #397
Conversation
5c3df59
to
0530f8c
Compare
This would indeed be a great test for the website |
I'm still looking, if I find better options to make this code more readable and maybe even shorter. |
10dcf75
to
a38ea2a
Compare
878108f
to
ef8723a
Compare
876054a
to
9ab7a97
Compare
9ab7a97
to
e00a42d
Compare
Okay, I think I'm done for now. I can't simplify it (at least currently). I fixed a few links, but on most of the ones I left, I'm unsure, where exactly I should link them to. I don't know the new docs enough to be sure about this. Here you can see the link check output rendered from md: https://github.com/nuejs/nue/actions/runs/11842921174?pr=397#summary-33002677721 |
It indeed catched broken links well. Is this safe to merge even though tit says "Some checks were not successful" ? |
Yes. The checks aren't successful, because there are still broken links. It should resolve itself over time, when fixing the links. If there's a case where the link check fails, even if it shouldn't, I'll probably update the test soon after. On larger changes, there might be some of those cases, but I'll take care of it :) |
I'll merge this now. |
Thanks! I'll go trough the links soon |
No description provided.