Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extend link checks #397

Merged
merged 5 commits into from
Nov 15, 2024
Merged

test: extend link checks #397

merged 5 commits into from
Nov 15, 2024

Conversation

nobkd
Copy link
Collaborator

@nobkd nobkd commented Nov 8, 2024

No description provided.

@tipiirai
Copy link
Contributor

This would indeed be a great test for the website

@nobkd
Copy link
Collaborator Author

nobkd commented Nov 14, 2024

I'm still looking, if I find better options to make this code more readable and maybe even shorter.

@nobkd nobkd force-pushed the test/link-check-fixes branch 2 times, most recently from 10dcf75 to a38ea2a Compare November 14, 2024 16:23
@nobkd nobkd force-pushed the test/link-check-fixes branch 4 times, most recently from 878108f to ef8723a Compare November 14, 2024 17:11
@nobkd nobkd force-pushed the test/link-check-fixes branch 5 times, most recently from 876054a to 9ab7a97 Compare November 14, 2024 17:36
@nobkd nobkd marked this pull request as ready for review November 14, 2024 18:04
@nobkd
Copy link
Collaborator Author

nobkd commented Nov 14, 2024

Okay, I think I'm done for now. I can't simplify it (at least currently).

I fixed a few links, but on most of the ones I left, I'm unsure, where exactly I should link them to. I don't know the new docs enough to be sure about this.

Here you can see the link check output rendered from md: https://github.com/nuejs/nue/actions/runs/11842921174?pr=397#summary-33002677721

@nobkd nobkd requested a review from tipiirai November 14, 2024 18:14
@tipiirai
Copy link
Contributor

It indeed catched broken links well. Is this safe to merge even though tit says "Some checks were not successful" ?

@nobkd
Copy link
Collaborator Author

nobkd commented Nov 15, 2024

Yes. The checks aren't successful, because there are still broken links.

It should resolve itself over time, when fixing the links.

If there's a case where the link check fails, even if it shouldn't, I'll probably update the test soon after. On larger changes, there might be some of those cases, but I'll take care of it :)

@nobkd
Copy link
Collaborator Author

nobkd commented Nov 15, 2024

I'll merge this now.
(And I might try to fix some more links later on)

@nobkd nobkd merged commit 6f715f0 into nuejs:master Nov 15, 2024
1 of 2 checks passed
@nobkd nobkd deleted the test/link-check-fixes branch November 15, 2024 14:49
@tipiirai
Copy link
Contributor

Thanks! I'll go trough the links soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants