feat!: escape {} templates #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #252
You can now use the following in html:
^\d\{4,5}$->^\d{4,5}$^\d\{4,5\}$->^\d{4,5}$^\d{4,5\}$->^\d{4,5}$E.g.
<input type="text" name="captcha" value="" placeholder="" required pattern="^\d\{4,5\}$" />For
\{as result double escaping is needed now:\\{->\{(html syntax) (would be\\\\{->\\{in js strings)You still cannot do something like:
{'\{fails\}'}->{'{fails}'}(does not result in maybe expected:'{fails}')PS: I'm not sure, if this should be merged, as it adds a bit of complexity to the regexp and has to recombine some strings to get back the expected format...
PPS: This might be breaking code for some people, but not really. It has parity with templates from before, but because of the new
\{/\}escaping, some (very small amount of) code has to change a little bit.