-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert unnecessary changes of bun.lockb in PR #149 #150
Conversation
Closing. let me check for sure again... |
✅ Checked and re-opening... Below is output from [[ git diff 16334ea ee64c01 -- bun.lockb ]] diff --git a/bun.lockb b/bun.lockb
index 3fce62c..853b438 100755
--- a/bun.lockb
+++ b/bun.lockb
@@ -1,123 +1,8 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
# yarn lockfile v1
-# bun ./bun.lockb --hash: 2CEF5A6DE7AD60F9-17c3d339555f4a51-36D751B931BC340D-779e4c6050698b75
+# bun ./bun.lockb --hash: 01C33369770C3C80-7bbaedb9804acfe5-FC545C77E671B54B-b6468c0bcba01140
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/aix-ppc64/-/aix-ppc64-0.19.11.tgz"
- integrity sha512-FnzU0LyE3ySQk7UntJO4+qIiQgI7KoODnZg5xzXIrFJlKd2P2gwHsHY4927xj9y5PJmJSzULiUCWmv7iWnNa7g==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/android-arm/-/android-arm-0.19.11.tgz"
- integrity sha512-5OVapq0ClabvKvQ58Bws8+wkLCV+Rxg7tUVbo9xu034Nm536QTII4YzhaFriQ7rMrorfnFKUsArD2lqKbFY4vw==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/android-arm64/-/android-arm64-0.19.11.tgz"
- integrity sha512-aiu7K/5JnLj//KOnOfEZ0D90obUkRzDMyqd/wNAUQ34m4YUPVhRZpnqKV9uqDGxT7cToSDnIHsGooyIczu9T+Q==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/android-x64/-/android-x64-0.19.11.tgz"
- integrity sha512-eccxjlfGw43WYoY9QgB82SgGgDbibcqyDTlk3l3C0jOVHKxrjdc9CTwDUQd0vkvYg5um0OH+GpxYvp39r+IPOg==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/darwin-arm64/-/darwin-arm64-0.19.11.tgz"
- integrity sha512-ETp87DRWuSt9KdDVkqSoKoLFHYTrkyz2+65fj9nfXsaV3bMhTCjtQfw3y+um88vGRKRiF7erPrh/ZuIdLUIVxQ==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/darwin-x64/-/darwin-x64-0.19.11.tgz"
- integrity sha512-fkFUiS6IUK9WYUO/+22omwetaSNl5/A8giXvQlcinLIjVkxwTLSktbF5f/kJMftM2MJp9+fXqZ5ezS7+SALp4g==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/freebsd-arm64/-/freebsd-arm64-0.19.11.tgz"
- integrity sha512-lhoSp5K6bxKRNdXUtHoNc5HhbXVCS8V0iZmDvyWvYq9S5WSfTIHU2UGjcGt7UeS6iEYp9eeymIl5mJBn0yiuxA==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/freebsd-x64/-/freebsd-x64-0.19.11.tgz"
- integrity sha512-JkUqn44AffGXitVI6/AbQdoYAq0TEullFdqcMY/PCUZ36xJ9ZJRtQabzMA+Vi7r78+25ZIBosLTOKnUXBSi1Kw==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/linux-arm/-/linux-arm-0.19.11.tgz"
- integrity sha512-3CRkr9+vCV2XJbjwgzjPtO8T0SZUmRZla+UL1jw+XqHZPkPgZiyWvbDvl9rqAN8Zl7qJF0O/9ycMtjU67HN9/Q==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/linux-arm64/-/linux-arm64-0.19.11.tgz"
- integrity sha512-LneLg3ypEeveBSMuoa0kwMpCGmpu8XQUh+mL8XXwoYZ6Be2qBnVtcDI5azSvh7vioMDhoJFZzp9GWp9IWpYoUg==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/linux-ia32/-/linux-ia32-0.19.11.tgz"
- integrity sha512-caHy++CsD8Bgq2V5CodbJjFPEiDPq8JJmBdeyZ8GWVQMjRD0sU548nNdwPNvKjVpamYYVL40AORekgfIubwHoA==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/linux-loong64/-/linux-loong64-0.19.11.tgz"
- integrity sha512-ppZSSLVpPrwHccvC6nQVZaSHlFsvCQyjnvirnVjbKSHuE5N24Yl8F3UwYUUR1UEPaFObGD2tSvVKbvR+uT1Nrg==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/linux-mips64el/-/linux-mips64el-0.19.11.tgz"
- integrity sha512-B5x9j0OgjG+v1dF2DkH34lr+7Gmv0kzX6/V0afF41FkPMMqaQ77pH7CrhWeR22aEeHKaeZVtZ6yFwlxOKPVFyg==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/linux-ppc64/-/linux-ppc64-0.19.11.tgz"
- integrity sha512-MHrZYLeCG8vXblMetWyttkdVRjQlQUb/oMgBNurVEnhj4YWOr4G5lmBfZjHYQHHN0g6yDmCAQRR8MUHldvvRDA==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/linux-riscv64/-/linux-riscv64-0.19.11.tgz"
- integrity sha512-f3DY++t94uVg141dozDu4CCUkYW+09rWtaWfnb3bqe4w5NqmZd6nPVBm+qbz7WaHZCoqXqHz5p6CM6qv3qnSSQ==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/linux-s390x/-/linux-s390x-0.19.11.tgz"
- integrity sha512-A5xdUoyWJHMMlcSMcPGVLzYzpcY8QP1RtYzX5/bS4dvjBGVxdhuiYyFwp7z74ocV7WDc0n1harxmpq2ePOjI0Q==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/linux-x64/-/linux-x64-0.19.11.tgz"
- integrity sha512-grbyMlVCvJSfxFQUndw5mCtWs5LO1gUlwP4CDi4iJBbVpZcqLVT29FxgGuBJGSzyOxotFG4LoO5X+M1350zmPA==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/netbsd-x64/-/netbsd-x64-0.19.11.tgz"
- integrity sha512-13jvrQZJc3P230OhU8xgwUnDeuC/9egsjTkXN49b3GcS5BKvJqZn86aGM8W9pd14Kd+u7HuFBMVtrNGhh6fHEQ==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/openbsd-x64/-/openbsd-x64-0.19.11.tgz"
- integrity sha512-ysyOGZuTp6SNKPE11INDUeFVVQFrhcNDVUgSQVDzqsqX38DjhPEPATpid04LCoUr2WXhQTEZ8ct/EgJCUDpyNw==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/sunos-x64/-/sunos-x64-0.19.11.tgz"
- integrity sha512-Hf+Sad9nVwvtxy4DXCZQqLpgmRTQqyFyhT3bZ4F2XlJCjxGmRFF0Shwn9rzhOYRB61w9VMXUkxlBy56dk9JJiQ==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/win32-arm64/-/win32-arm64-0.19.11.tgz"
- integrity sha512-0P58Sbi0LctOMOQbpEOvOL44Ne0sqbS0XWHMvvrg6NE5jQ1xguCSSw9jQeUk2lfrXYsKDdOe6K+oZiwKPilYPQ==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/win32-ia32/-/win32-ia32-0.19.11.tgz"
- integrity sha512-6YOrWS+sDJDmshdBIQU+Uoyh7pQKrdykdefC1avn76ss5c+RN6gut3LZA4E2cH5xUEp5/cA0+YxRaVtRAb0xBg==
-
-"@esbuild/[email protected]":
- version "0.19.11"
- resolved "https://registry.npmjs.org/@esbuild/win32-x64/-/win32-x64-0.19.11.tgz"
- integrity sha512-vfkhltrjCAb603XaFhqhAF4LGDi2M4OrCRrFusyQ+iTLQ/o60QQXxc9cZC/FFpihBI9N1Grn6SMKVJ4KP7Fuiw==
-
argparse@^2.0.1:
version "2.0.1"
resolved "https://registry.npmjs.org/argparse/-/argparse-2.0.1.tgz"
@@ -163,35 +48,6 @@ entities@^4.2.0, entities@^4.5.0:
resolved "https://registry.npmjs.org/entities/-/entities-4.5.0.tgz"
integrity sha512-V0hjH4dGPh9Ao5p0MoRY6BVqtwCjhz6vI5LT8AJ55H+4g9/4vbHx1I54fS0XuclLhDHArPQCiMjDxjaL8fPxhw==
-esbuild@^0.19.11:
- version "0.19.11"
- resolved "https://registry.npmjs.org/esbuild/-/esbuild-0.19.11.tgz"
- integrity sha512-HJ96Hev2hX/6i5cDVwcqiJBBtuo9+FeIJOtZ9W1kA5M6AMJRHUZlpYZ1/SbEwtO0ioNAW8rUooVpC/WehY2SfA==
- optionalDependencies:
- "@esbuild/aix-ppc64" "0.19.11"
- "@esbuild/android-arm" "0.19.11"
- "@esbuild/android-arm64" "0.19.11"
- "@esbuild/android-x64" "0.19.11"
- "@esbuild/darwin-arm64" "0.19.11"
- "@esbuild/darwin-x64" "0.19.11"
- "@esbuild/freebsd-arm64" "0.19.11"
- "@esbuild/freebsd-x64" "0.19.11"
- "@esbuild/linux-arm" "0.19.11"
- "@esbuild/linux-arm64" "0.19.11"
- "@esbuild/linux-ia32" "0.19.11"
- "@esbuild/linux-loong64" "0.19.11"
- "@esbuild/linux-mips64el" "0.19.11"
- "@esbuild/linux-ppc64" "0.19.11"
- "@esbuild/linux-riscv64" "0.19.11"
- "@esbuild/linux-s390x" "0.19.11"
- "@esbuild/linux-x64" "0.19.11"
- "@esbuild/netbsd-x64" "0.19.11"
- "@esbuild/openbsd-x64" "0.19.11"
- "@esbuild/sunos-x64" "0.19.11"
- "@esbuild/win32-arm64" "0.19.11"
- "@esbuild/win32-ia32" "0.19.11"
- "@esbuild/win32-x64" "0.19.11"
-
htmlparser2@^9.0.0:
version "9.0.0"
resolved "https://registry.npmjs.org/htmlparser2/-/htmlparser2-9.0.0.tgz"
@@ -209,7 +65,7 @@ js-yaml@^4.1.0:
dependencies:
argparse "^2.0.1"
-marked@^9.1.2:
+marked@^9.1.6:
version "9.1.6"
resolved "https://registry.npmjs.org/marked/-/marked-9.1.6.tgz"
integrity sha512-jcByLnIFkd5gSXZmjNvS1TlmRhCXZjIzHYlaGkPlLIekG55JDR2Z4va9tZwCiP+/RDERiNhMOFu01xd6O5ct1Q==
@@ -230,10 +86,8 @@ nuejs-core@^0.3.0:
"nuekit@packages/nuekit":
version "workspace:packages/nuekit"
resolved "workspace:packages/nuekit"
- devDependencies:
- esbuild "^0.19.11"
dependencies:
diff-dom "^5.0.6"
js-yaml "^4.1.0"
- marked "^9.1.2"
+ marked "^9.1.6"
nuejs-core "^0.3.0" |
Cool, thanks! Care to explain to me what happens here? I'm not familiar with lock files. |
@tipiirai PR #149 included some unexpected changes (the bun.lockb) I didn't notice and getting merged 🚀 : To view bun.lockb: just run So I had to submmit this PR to revert them (removing those changes irrelavant to droping esbuild): As for the reason how they come into for the first time, I don't know either 😂 . I just tried bun install again to eliminate them. Lockfiles are just a dump of all the dependencies of the current state of the project. I'm not a pro either. I will just trying to keep it as clean as possible while committing. |
Also not really in the matter either... Lock files contain the information about each used package, the ones explicitly referenced and also all their dependencies. They allow for example reproducible builds by installing exactly the same package versions as before. You can install from the lock-file with |
Thanks, good to know them. But I wasn't able to run just
So how to remove esbuild with the other things untouched? |
Thanks for the explanation @nobkd! I hope they are not a source of git conflicts when working with branches. I often find myself removing them because I feel they are on my way. Need to fix bad habits. |
Sorry, I don't know how to do that, but I don't think, it would influence the package versions in a bad way. I think it is okay to have changed package versions apart from esbuild related ones. There, most-likely, aren't even major changes.. |
Another great thing I found out about lock-files: Lock-files can also really speed up installation, because the package manager does not have to build the complete dependency tree over and over. That is at least my assumption with That would also be a reason to keep the lock-file up to date. Changes to the lower level dependency tree don't have to be detected on each Aside from my personal findings, I haven't found any note about this, so take it with a grain of salt. (also, I haven't really looked around) |
Sorry for the unnecessary changes (bun.lockb) in last PR #149 , here is the revert >_<
Below is the
git diff bun.lockb
in this PR: