Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on not_ready(), always check service readiness #184

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

fafhrd91
Copy link
Member

@fafhrd91 fafhrd91 commented Nov 5, 2024

No description provided.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (9de1db1) to head (4ff4f6f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   70.14%   70.12%   -0.02%     
==========================================
  Files          52       52              
  Lines        8838     8827      -11     
==========================================
- Hits         6199     6190       -9     
+ Misses       2639     2637       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fafhrd91 fafhrd91 merged commit e5e2906 into master Nov 5, 2024
23 checks passed
@fafhrd91 fafhrd91 deleted the not-ready branch November 5, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant