This repository has been archived by the owner on Nov 28, 2023. It is now read-only.
Fix the hello-world example code #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the initial example on the demo page gives a `Children must be a list of VDOM objects or strings` which is not a great first experience with the project ;) Python lists of VDOM objects are neither VDOM objects nor strings so they trigger the error. If we splice the results of the `fancy` call into the `h1` arguments list (so each list element becomes a separate argument to `h1`) then the code works correctly.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nteract/play/DoGfa9PRwXyr6XVieYAZbZDSvLbU |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the initial example on the demo page gives a
Children must be a list of VDOM objects or stringswhich is not a great first experience with the project ;)Python lists of VDOM objects are neither VDOM objects nor strings so they trigger the error. If we splice the results of the
fancycall into theh1arguments list (so each list element becomes a separate argument toh1) then the code works correctly.