Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 62 #93

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Issue 62 #93

wants to merge 31 commits into from

Conversation

eigenbeam
Copy link
Contributor

No description provided.

Copy link
Contributor

@afitzgerrell afitzgerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi kevin, (woops! completely re-edited since originally commenting) i think this looks great. i was looking at the diff and i should have just looked at the "done" view of the readme!!

@eigenbeam eigenbeam marked this pull request as ready for review November 26, 2024 20:53
@@ -31,16 +34,7 @@ or

$ python3 --version

Next, install [Poetry](https://python-poetry.org/) by using the [official
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't we still need some of this information for anyone developing the tool? My answer is "yes" but these changes indicate you say "no." We could move some content to a DEVELOPER.md file if the README needs to be lean.


* Bump the version to the desired number, for example:

$ bump-my-version bump minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading this right, you'll need to know the version you're bumping to before you update the CHANGELOG (unless there's a bump option to automatically replace some placeholder text with the actual version in the CHANGELOG itself). In that case, lines 222 and 223 would be more logical if moved after line 230.

$ bump-my-version bump minor

You will see the latest commit & tag by looking at `git log`. You
can then push these to GitHub to trigger the CI/CD workflow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't hurt to expressly say "you can now do git push to push the changes to GitHub and trigger..."

version = "0.1.0"
description = "The nsidc-metgen package enables data producers as well as Operations staff managing the data ingest workflow to create metadata files conforming to NASA's Common Metadata Repository UMM-G specification."
name = "nsidc-metgenc"
version = "0.4.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does bump-my-version automatically update this value? (Oh, I really really hope so!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants