-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(angular): document PNPM workaround for ngcc #18100
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 302547f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
f207d5f
to
5d1de44
Compare
I don't understand why the build is failing, there are no error messages in the build console logs |
Needed to run If you run |
Closed in favor of #19041 |
No worries, thanks for helping to fix it! |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Currently, https://nx.dev/recipes/other/setup-incremental-builds-angular#requirements still warns that
ngcc
doesn't support PNPM.Expected Behavior
While
ngcc
doesn't support PNPM out-of-the-box, PNPM has since added a node-linker=hoisted mode that creates flatnode_modules
without symlinks, similar to thenode_modules
created by NPM, allowingngcc
to work with PNPM (angular/angular#50735).Unfortunately, using
node-link=hoisted
breaks@parcel/watcher
that is used by NX (#16319 and parcel-bundler/watcher#142). A workaround is to explicitly declarenode-gyp-build
inpackage.json
, e.g.This PR documents the workarounds to use
ngcc
with PNPM.p.s. Huge thanks to @DzmVasileusky for discovering the workarounds.