feat(arborist)!: install optional peer dependencies #5301
+42,173
−2,367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current versions of npm do not attempt to install optional peer dependencies, this feature changes that. one caveat of this is that in the event of an optional peer and a regular peer conflicting, we will allow the optional peer to become invalid (meaning the non-optional peer takes precedence). we opted to take this approach in the hopes that it would minimize new
ERESOLVE
errors due to these new dependencies being installed.for the moment we're considering this as a breaking change due to the potential for
package-lock.json
churn, as well as the potential for new bugs to surface. as such, it is unlikely that we will land this change before the first release of npm 9.closes #4859