Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Strict-Code and PHP8 Requirement #7

Draft
wants to merge 8 commits into
base: v2
Choose a base branch
from
Draft

Draft: Strict-Code and PHP8 Requirement #7

wants to merge 8 commits into from

Conversation

JustinBack
Copy link

Draft PR for Work in Progress.

This Refactor Contains:

  • Getters in Resources
  • Strict Typing Variables and Functions
  • Class Variables in Constructors

@JustinBack JustinBack changed the title DRAFT: Strict-Code and PHP8 Requirement Draft: Strict-Code and PHP8 Requirement Mar 9, 2023
@JustinBack JustinBack marked this pull request as draft March 9, 2023 14:31
unicodeveloper
unicodeveloper reviewed Mar 15, 2023
View reviewed changes
Copy link
Contributor

@unicodeveloper unicodeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @JustinBack. Looking forward to the rest of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unicodeveloper unicodeveloper unicodeveloper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustinBack @unicodeveloper