Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.x 🚀 #341

Merged
merged 23 commits into from
Jun 7, 2019
Merged

Release v2.x 🚀 #341

merged 23 commits into from
Jun 7, 2019

Conversation

BcRikko
Copy link
Member

@BcRikko BcRikko commented May 31, 2019

Minor update(bug fix) & Security update📦 🚀

lucasjs and others added 12 commits March 30, 2019 21:01
fix: remove underline in hover and set color
fix: remove input shadow on ios
a vulnerability was found in node-tar before version 4.4.2.
Add select is-dark class type like input component
I’ve added a SCSS function that, when passed a file path, will inject the file as a data URI. This
is super helpful since it ensures that the cursor images will always be available for the CSS. This
issue currently prevents the npm version of the library from being usable at all.
@BcRikko BcRikko requested a review from a team May 31, 2019 02:42
@BcRikko BcRikko self-assigned this May 31, 2019
@trezy
Copy link
Member

trezy commented Jun 4, 2019

I'd like to request that we hold off on the 2.0 release until we've updated the library to remove the current icons and replaced them with NES.icons. This is because the NES.icons library has some collision issues with NES.css due to icon class names being the same. I'm hoping to have the NES.icons site done and up sometime this week. After that, I'll work on getting a PR in to NES.css to update the icons. 😁

@BcRikko
Copy link
Member Author

BcRikko commented Jun 4, 2019

This PR is a minor update that includes security updates and bug fixes. 👮
And v2.x has been released. so the current version of NES.css is v2.1.1.

Removing icons from NES.css has a big impact, so I'd like to work on it in the Next version 🚀
Until then, it's better to load nes-core.css and use it.

<link href="https://unpkg.com/nes.css@latest/css/nes-core.min.css" rel="stylesheet" />
<link href="https://unpkg.com/nes.icons@latest/css/nes.min.css" rel="stylesheet" />

@trezy
Copy link
Member

trezy commented Jun 4, 2019

@BcRikko Yup, that makes sense. I was under the impression that we were still on v1.x. 😜

@guastallaigor
Copy link
Member

@BcRikko Yup, that makes sense. I was under the impression that we were still on v1.x.

We also thought that when we made the last release 😄, but I think semantic-release put the version in 2.x because of some breaking changes.

Copy link
Member

@guastallaigor guastallaigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Tested almost every component variation using storybook, and checked the docs in Brave (chromium) and Firefox, both up to date.

@BcRikko BcRikko merged commit 41f2abb into master Jun 7, 2019
@BcRikko
Copy link
Member Author

BcRikko commented Jun 7, 2019

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants