Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dense Fisher EKF #96

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Dense Fisher EKF #96

merged 7 commits into from
Jun 3, 2024

Conversation

jcqcai
Copy link
Contributor

@jcqcai jcqcai commented May 27, 2024

I went ahead and gave my shot at implementing dense fisher EKF. Please let me know if anything needs modification. Thank you!

@jcqcai jcqcai mentioned this pull request May 27, 2024
Copy link
Contributor

@SamDuffield SamDuffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Only a couple of points to discuss

Edit: Oh! One more thing, we should add a bullet point to docs/api/index.md briefly describing the algorithm

posteriors/ekf/dense_fisher.py Outdated Show resolved Hide resolved
tests/ekf/test_dense_fisher.py Outdated Show resolved Hide resolved
Copy link
Contributor

@SamDuffield SamDuffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me! Great stuff 🥳

@SamDuffield SamDuffield merged commit 24d79e8 into normal-computing:main Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants