Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dense Hessian Laplace #112

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Dense Hessian Laplace #112

merged 4 commits into from
Oct 10, 2024

Conversation

jcqcai
Copy link
Contributor

@jcqcai jcqcai commented Oct 7, 2024

I went ahead and gave my shot at implementing dense hessian laplace. Please let me know if anything needs modification. Thank you!

@jcqcai jcqcai mentioned this pull request Oct 7, 2024
Copy link
Contributor

@SamDuffield SamDuffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, thanks!!!

A couple of minor points and then I reckon we'd be good to merge

posteriors/laplace/dense_hessian.py Show resolved Hide resolved
posteriors/laplace/dense_hessian.py Show resolved Hide resolved
posteriors/laplace/dense_hessian.py Show resolved Hide resolved
Copy link
Contributor

@SamDuffield SamDuffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@SamDuffield SamDuffield merged commit 3505484 into normal-computing:main Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants