Merge pull request #97 from normal-computing/inplace-False

Ensure inplace defaults to False
normal-computing · Jun 5, 2024 · 03de980 · 03de980
2 parents 6152010 + 1ebd9e8
commit 03de980
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/posteriors/laplace/dense_fisher.py b/posteriors/laplace/dense_fisher.py
@@ -100,7 +100,7 @@ def update(
     batch: Any,
     log_posterior: LogProbFn,
     per_sample: bool = False,
-    inplace: bool = True,
+    inplace: bool = False,
 ) -> DenseLaplaceState:
     """Adds empirical Fisher information matrix of covariance summed over
     given batch.

diff --git a/posteriors/torchopt.py b/posteriors/torchopt.py
@@ -82,7 +82,7 @@ def update(
     batch: TensorTree,
     loss_fn: LogProbFn,
     optimizer: torchopt.base.GradientTransformation,
-    inplace: bool = True,
+    inplace: bool = False,
 ) -> TorchOptState:
     """Update the [TorchOpt](https://github.com/metaopt/torchopt) optimizer state.