Close non-standard file descriptors #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The obs-ffmpeg-mux process cannot be terminated while the process forked by this plugin is running, which causes audio subsystem of OBS stalls. The obs-ffmpeg-mux process is terminated when an EOF appears on the pipe. However, since the forked process holds the file descriptor of the write-end of the pipe, the EOF won't arrive to the obs-ffmpeg-mux process.
How Has This Been Tested?
Tested on Linux and macOS.
sleep 60
from this plugin.sleep 1m
).General checklist