Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node.chipid() returns "0x_unknown" for ESP32xx chips #3651

Closed
wants to merge 1 commit into from

Conversation

serg3295
Copy link

@serg3295 serg3295 commented May 11, 2024

  • This PR is for the dev branch rather than for the release branch.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

The reason for this change is that the nodemcu-tool utility expects the node.chipid() command to exist in the Lua environment.
However, ESP32c6|s2|h2 chips do not have a chipid, so node.chipid() function will return 0x_unknown for these chips.

@marcelstoer
Copy link
Member

marcelstoer commented May 12, 2024

ESP32c6|s2|h2 chips do not have a chipid, so node.chipid() function will return 0x_unknown

Shouldn't the docs in node.md mention this? There's a - now outdated - comment in #3652.

@serg3295 serg3295 mentioned this pull request May 13, 2024
4 tasks
@serg3295 serg3295 closed this May 20, 2024
@serg3295 serg3295 deleted the esp32-chipid branch May 20, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants