Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace ts-node with tsx #518

Merged
merged 1 commit into from
Jul 12, 2024
Merged

chore: replace ts-node with tsx #518

merged 1 commit into from
Jul 12, 2024

Conversation

wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Jul 11, 2024

Depends on #517

Why the change?
ts-node is currently in a bit questionable shape. It barely works with newer versions od Node.js, long-standing bugs are not being addressed, TypeScript + ESM simply does not work.
I myself was affected by ts-node simply hanging on start during yarn build command on Windows.

Why tsx?
While my personal favorite ts-node alternative is tsimp, tsx has seen much higher adoption so far, so I believe it's easier for others to accept it. It also uses esbuild under the hood, which we happen to already use, which results in a considerable drop of number of dependencies.

@wojtekmaj wojtekmaj marked this pull request as ready for review July 12, 2024 10:11
@aduh95 aduh95 enabled auto-merge (squash) July 12, 2024 10:28
auto-merge was automatically disabled July 12, 2024 12:25

Head branch was pushed to by a user without write access

@aduh95 aduh95 merged commit 932bd4e into nodejs:main Jul 12, 2024
13 checks passed
@wojtekmaj wojtekmaj deleted the tsx branch July 12, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants