Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design note for converting SUBFLOW to NPM #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HiroyasuNishiyama
Copy link
Member

This PR add design note for converting SUBFLOW to NPM module.

Currently Node-RED nodes are distributed as NPM module. There is a design proposal that enable a SUBFLOW to be exported as a node in JSON format (https://github.com/node-red-hitachi/designs/blob/subflow-encryption/designs/exportable-subflow/README.md).

Even if redistributing SUBFLOW in JSON format is possible, it is useful to convert it to NPM format for the following reasons. Therefore, this design note proposes a method of converting JSON-formatted SUBFLOW nodes into NPM modules.

@knolleary
Copy link
Member

This is a good start.

Do you have any thoughts on how the runtime then makes use of the subflow json? That is going to be the hard part of this feature and I would like some discussion on the internal changes needed.

@HiroyasuNishiyama
Copy link
Member Author

My assumption is that SUBFLOW definition with registerSubflow is handled through a normal flow import path. I think that we can do the same with a little additional verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants