Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dcellar-web-ui): unified encoding method same as go-sdk #387

Merged
merged 5 commits into from
May 30, 2024
Merged

fix(dcellar-web-ui): unified encoding method same as go-sdk #387

merged 5 commits into from
May 30, 2024

Conversation

devinxl
Copy link
Collaborator

@devinxl devinxl commented May 28, 2024 •
edited
Loading

  • fix(dcellar-web-ui): unified encoding method same as go-sdk

Description

Issue ticket number and link

Types of changes

  • Docs refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated changeset
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@devinxl devinxl changed the title fix/compatible chinese symbol fix(dcellar-web-ui): unified encoding method same as go-sdk May 28, 2024
@devinxl
Copy link
Collaborator Author

devinxl commented May 28, 2024 •
edited by github-actions bot
Loading

/e2e-deploy-testnet:dcellar-web-ui
++++++{2024-05-28T07:00:05}++++++
Action Runner: https://github.com/node-real/dcellar-fe/actions/runs/9264875861
++++++
Congrats, e2e-deploy successfully!
Preview Url: https://dc-387.dcellar-web-ui.fe.nodereal.cc
Build Id: bca052c

@devinxl devinxl merged commit ea64198 into main May 30, 2024
3 checks passed
@devinxl devinxl deleted the fix/compatible-chinese-symbol branch May 30, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiden-cao aiden-cao aiden-cao approved these changes

@wenty22 wenty22 Awaiting requested review from wenty22 wenty22 is a code owner

@ybgbob ybgbob Awaiting requested review from ybgbob ybgbob is a code owner

@Miyaww Miyaww Awaiting requested review from Miyaww Miyaww is a code owner

@declangg declangg Awaiting requested review from declangg declangg is a code owner

@Rosyya Rosyya Awaiting requested review from Rosyya Rosyya is a code owner

Assignees
No one assigned
Labels
dcellar-web-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinxl @aiden-cao