Update constraints to torch 2.4 dynamic_shapes API #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-garvey
approved these changes
Aug 7, 2024
| } | ||
| for dim_number in range(1, len(state_arg)): | ||
| current_dim_dict = {f"arg{dim_number + 1}_1": {1: state_arg0_dim1}} | ||
| dynamic_shapes_forw = {**dynamic_shapes_forw, **current_dim_dict} |
There was a problem hiding this comment.
does this need to be inside the for loop?
There was a problem hiding this comment.
Yup, we are basically adding another entry to the dictionary for every state arg dim dynamic shape constraint. It's just unpacking both dictionaries and combining them. Because the current entry is being reassigned every iteration, we need the dict concat within the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates to use dynamic_shapes for dynamic dimensions as the usage of constraints is deprecated in torch 2.4. (The SHARK test checks out the main branch of this repo and will pass once this is merged)