Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #21

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Develop #21

merged 4 commits into from
Oct 3, 2024

Conversation

jimbrig
Copy link
Member

@jimbrig jimbrig commented Jun 12, 2024

Have you read the Contributing Guidelines?

Issue #

Changes description

Clearly and concisely describe what's in this pull request. Include screenshots, if necessary.

Copy link

height bot commented Jun 12, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bastienlaw-dev ❌ Failed (Inspect) Oct 3, 2024 6:31pm
bastienlaw-remix ❌ Failed (Inspect) Oct 3, 2024 6:31pm
bastienlaw-remix-eqnq ❌ Failed (Inspect) Oct 3, 2024 6:31pm

@phoward38
Copy link
Member

@jimbrig lgtm. I added a catchall route handler, which works fine locally but not sure why it messed up the deployment

@jimbrig
Copy link
Member Author

jimbrig commented Aug 17, 2024

@phoward38 do we need this code?

@phoward38
Copy link
Member

@jimbrig yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants