Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Refactoring and Cleanup #82

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Code Refactoring and Cleanup #82

merged 4 commits into from
Apr 16, 2024

Conversation

joelsmith-2019
Copy link
Contributor

Closes #81

  • Refactors redundant, usually pertaining to timer logic within routines
  • Fixes a URL link
  • Fixes a blocking issue within a select statement

This project still needs some linting work, but that'll be for another PR.

@joelsmith-2019 joelsmith-2019 self-assigned this Apr 16, 2024
@Reecepbcups
Copy link
Contributor

Reecepbcups commented Apr 16, 2024 •
edited
Loading

FYI check out conventional commits for titles :) something like refactor(timer): block queues & heights is more descriptive and a nice to have.

@joelsmith-2019 joelsmith-2019 merged commit 9f4cf29 into main Apr 16, 2024
5 checks passed
@joelsmith-2019 joelsmith-2019 deleted the joel/refactoring branch April 16, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reecepbcups Reecepbcups Reecepbcups approved these changes

Assignees

@joelsmith-2019 joelsmith-2019

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring and Cleanup
2 participants
@joelsmith-2019 @Reecepbcups