fix: add checks on ResultBroadcastTx to avoid NPE + cleanup error handling code
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boojamya
reviewed
Nov 17, 2023
| // Log the error | ||
| logger.Error(fmt.Sprintf("error during broadcast: %s", getErrorString(err, rpcResponse))) | ||
|
|
||
| if err != nil || rpcResponse == nil { |
There was a problem hiding this comment.
Since this is nested in the previous "if" statement, is this if err != ni necessary?
| @@ -66,7 +67,7 @@ func StartListener(cfg config.Config, logger log.Logger, processingQueue chan *t | |||
| for _, historicalLog := range history { | |||
| parsedMsg, err := types.EvmLogToMessageState(messageTransmitterABI, messageSent, &historicalLog) | |||
| if err != nil { | |||
| logger.Error("Unable to parse history log into MessageState, skipping") | |||
| logger.Error("Unable to parse history log into MessageState, skipping", "err", err) | |||
There was a problem hiding this comment.
Nice. I had the same idea in order to help with issues like #9.
I think this PR could close out that issue too.
|
Also, we should merge into |
This was referenced Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional check on
ResultBroadcastTx, which is returned byBroadcastTxSync, to ensure the result is not nil before attempting to log the response code and logs.This also cleans up the error handling code to remove duplicate code and separates concerns into smaller functions for better readability and maintainability.
Closes #17