Upgrade plugin tools #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrade supports usage as a subplugin. In some special cases it is wanted to use the plugin from inside another plugin. Upgrade qgis-plugin-tool to a version that supports this.
komima
approved these changes
Jan 25, 2024
|
Test failed because settings are stored and get from outside of plugin package. Therefore those are not handled as plugin settings. Before these tests passed because the bug in qgis_plugin_tools which was fixed in GispoCoding/qgis_plugin_tools@227222d. If settings were set inside from plugin package at the first time the plugin name was cached. |
In the tests settings are modified outside the plugin package. Therefore settings are not saved correctly as internal settings since the plugin_name is not available. Patch plugin_name when accessing settings.
komima
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade
qgis-plugin-toolto 0.4.0. This upgrade supports the usage as a subplugin.Type of change
Bug fix
New feature
Other
Non-breaking change
Breaking change
Developer checklist