Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Asset type #373

Merged
merged 2 commits into from
Oct 22, 2024
Merged

fix Asset type #373

merged 2 commits into from
Oct 22, 2024

Conversation

langovoi
Copy link
Contributor

@langovoi langovoi commented Sep 18, 2024

I found that Asset type is wrong.

As I understood this is always object which has tag and attrs. When tag is 'script' | 'style', it also could be children: string in it.

So I updated type for this.

Copy link

codesandbox bot commented Sep 18, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vinxi-website ❌ Failed (Inspect) Oct 22, 2024 6:44pm

Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: c261150

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
vinxi Patch
@vinxi/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@toakleaf toakleaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would have saved me some time today 😄

@nksaraf nksaraf merged commit 2dbda1d into nksaraf:main Oct 22, 2024
7 of 8 checks passed
Copy link

pkg-pr-new bot commented Oct 22, 2024

Open in Stackblitz

@vinxi/deno-doc

pnpm add https://pkg.pr.new/@vinxi/deno-doc@373

vinxi

pnpm add https://pkg.pr.new/vinxi@373

@vinxi/plugin-directives

pnpm add https://pkg.pr.new/@vinxi/plugin-directives@373

@vinxi/doc

pnpm add https://pkg.pr.new/@vinxi/doc@373

@vinxi/plugin-mdx

pnpm add https://pkg.pr.new/@vinxi/plugin-mdx@373

@vinxi/openapi

pnpm add https://pkg.pr.new/@vinxi/openapi@373

@vinxi/react

pnpm add https://pkg.pr.new/@vinxi/react@373

@vinxi/react-server

pnpm add https://pkg.pr.new/@vinxi/react-server@373

@vinxi/router

pnpm add https://pkg.pr.new/@vinxi/router@373

@vinxi/server-components

pnpm add https://pkg.pr.new/@vinxi/server-components@373

@vinxi/server-functions

pnpm add https://pkg.pr.new/@vinxi/server-functions@373

@vinxi/solid

pnpm add https://pkg.pr.new/@vinxi/solid@373

commit: c261150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants