Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vite --mode #359

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

XiNiHa
Copy link
Contributor

@XiNiHa XiNiHa commented Aug 30, 2024

This PR adds support for Vite modes

Copy link

codesandbox bot commented Aug 30, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: 1b4381a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
vinxi Patch
@vinxi/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 30, 2024

@XiNiHa is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

pkg-pr-new bot commented Aug 30, 2024

Open in Stackblitz

vinxi

pnpm add https://pkg.pr.new/vinxi@359

@vinxi/plugin-directives

pnpm add https://pkg.pr.new/@vinxi/plugin-directives@359

@vinxi/plugin-mdx

pnpm add https://pkg.pr.new/@vinxi/plugin-mdx@359

@vinxi/doc

pnpm add https://pkg.pr.new/@vinxi/doc@359

@vinxi/openapi

pnpm add https://pkg.pr.new/@vinxi/openapi@359

@vinxi/react

pnpm add https://pkg.pr.new/@vinxi/react@359

@vinxi/react-server

pnpm add https://pkg.pr.new/@vinxi/react-server@359

@vinxi/router

pnpm add https://pkg.pr.new/@vinxi/router@359

@vinxi/server-components

pnpm add https://pkg.pr.new/@vinxi/server-components@359

@vinxi/server-functions

pnpm add https://pkg.pr.new/@vinxi/server-functions@359

@vinxi/solid

pnpm add https://pkg.pr.new/@vinxi/solid@359

@vinxi/deno-doc

pnpm add https://pkg.pr.new/@vinxi/deno-doc@359

commit: 1b4381a

@LexSwed
Copy link

LexSwed commented Sep 2, 2024

Closes #304 ❤️

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vinxi-website ❌ Failed (Inspect) Sep 3, 2024 7:07am

@nksaraf
Copy link
Owner

nksaraf commented Sep 3, 2024

Does it need a default, or its okay to be null if nothing is passed by the user, vite picks up the correct default somehow?

@XiNiHa
Copy link
Contributor Author

XiNiHa commented Sep 3, 2024

Does it need a default, or its okay to be null if nothing is passed by the user, vite picks up the correct default somehow?

Vite sets the default, as needed

@ryansolid ryansolid merged commit cb790e1 into nksaraf:main Sep 3, 2024
7 of 8 checks passed
@XiNiHa XiNiHa deleted the feat/vite-mode branch September 4, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants