-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add treefmt and re-format codebase #237
base: master
Are you sure you want to change the base?
Conversation
0106dad
to
79cd7a5
Compare
Hm, maybe I should add EDIT: nevermind, forgot how error-prone that is — I thin it's ultimately better to suffer a few supwrfluous dependencies than weird corner–cases of NixCpp. |
I think this is ultimately ready for review, but will be easier too look at after #236 is merged, as they share commits and I don't really see way to stack PRs against forks in GH, like you can in a single repo. |
251a0ea
to
8d1fd2b
Compare
Back to a draft for now due to tooling discussion in #239 (comment) |
Treefmt now resolved those two issues: |
Sets up treefmt for:
nixfmt-rfc-style
,ruff
(supposedly aflake8
drop-in replacement) andmypy
,shellcheck
andshellfmt
,actionlint
.I have followed excludes from https://github.com/nix-community/robotnix/blob/master/scripts/check.sh and fixed any issues (minor type/lint issues in Python). Next step would be probably to re-enable checking this in CI.
This is based on top of #236, so it has to go in first.