Added mute functionality to module #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on chromium or chrome if video is not muted autoplay won't work. Added mute option to enable autoplay when sound is not important.
Added mute config option
Added mute option to readme
nitpum
reviewed
Apr 13, 2022
| @@ -41,6 +42,7 @@ Module.register("MMM-EmbedYoutube", { | |||
| } | |||
| } | |||
| params += (this.config.autoplay) ? "autoplay=1" : "autoplay=0"; | |||
| params += (this.config.mute) ? "&mute=1" : "&mute=0"; | |||
There was a problem hiding this comment.
Where did you get mute? I can't find this parameters from Youtube IFrame API docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on chromium video won't autoplay when is not muted. To patch this mute option is added.