Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with neurolucida 360. #804

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

alan-wu
Copy link
Contributor

@alan-wu alan-wu commented Mar 19, 2024

Description

This fixes a problem with neurolucida as described in this ticket - https://www.wrike.com/open.htm?id=1324988860
Once this deployed, the neurolucida 360 button should work in the following route:
datasets/file/367/1?path=files/derivative/sub-rat01/sam-01/sub-rat01-sam-section2-ses-massons+trichrome.jp2

Type of change

Delete those that don't apply.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test this locally.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

@alan-wu alan-wu requested a review from egauzens March 19, 2024 07:31
Copy link

cypress bot commented Mar 19, 2024

1 failed test on run #57 ↗︎

1 46 4 0 Flakiness 0

Details:

Fix an issue with neurolucida 360.
Project: SPARC Portal E2E testing Commit: b279becdb2
Status: Failed Duration: 08:40 💡
Started: Mar 19, 2024 7:27 AM Ended: Mar 19, 2024 7:36 AM
Failed  test/cypress/e2e/homepage.cy.js • 1 failed test

View Output Video

Test Artifacts
Homepage > Footer Screenshots Video

Review all test suite changes for PR #804 ↗︎

@egauzens egauzens merged commit 098d5cb into nih-sparc:master Mar 19, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants