Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using specific datasets for userstory testing #794

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

ddjnw1yu
Copy link
Collaborator

@ddjnw1yu ddjnw1yu commented Jan 7, 2024

Description

Fixed the failed tests here. Using specific datasets for each testing case to make sure tests still passed after new datasets have been added.

Type of change

Delete those that don't apply.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Updated tests are run by Cypress locally in MacOS.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

Copy link

cypress bot commented Jan 7, 2024

Passing run #42 ↗︎

0 50 1 0 Flakiness 0

Details:

using specific datasets for testing
Project: SPARC Portal E2E testing Commit: 70b3342fa3
Status: Passed Duration: 06:48 💡
Started: Jan 7, 2024 9:57 PM Ended: Jan 7, 2024 10:04 PM

Review all test suite changes for PR #794 ↗︎

@ddjnw1yu ddjnw1yu requested a review from alan-wu January 7, 2024 22:05
Copy link
Contributor

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@alan-wu alan-wu merged commit 6ad59dc into nih-sparc:master Jan 7, 2024
2 checks passed
@ddjnw1yu ddjnw1yu deleted the user-stories-testing branch January 8, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants