Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add null check to userToken #791

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

egauzens
Copy link
Contributor

Description

isEmpty does not check for null so added this check

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

Copy link

cypress bot commented Dec 21, 2023

Passing run #39 ↗︎

0 50 1 0 Flakiness 0

Details:

add null check to userToken
Project: SPARC Portal E2E testing Commit: 5c18767bc9
Status: Passed Duration: 07:02 💡
Started: Dec 21, 2023 9:30 PM Ended: Dec 21, 2023 9:37 PM

Review all test suite changes for PR #791 ↗︎

@egauzens egauzens merged commit 50a00ba into nih-sparc:master Dec 22, 2023
2 checks passed
@egauzens egauzens deleted the fix-dataset-info-bug branch December 22, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants