Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed call to download file mixin to include version #790

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

egauzens
Copy link
Contributor

Description

Included version in call to method since file info no longer contains dataset version after migration.

Type of change

Delete those that don't apply.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Locally

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

Copy link

cypress bot commented Dec 21, 2023

Passing run #38 ↗︎

0 50 1 0 Flakiness 0

Details:

added version to files table download
Project: SPARC Portal E2E testing Commit: a6764fc1f8
Status: Passed Duration: 07:27 💡
Started: Dec 21, 2023 6:46 PM Ended: Dec 21, 2023 6:53 PM

Review all test suite changes for PR #790 ↗︎

@egauzens egauzens merged commit cafa92c into nih-sparc:master Dec 21, 2023
2 checks passed
@egauzens egauzens deleted the fix-download-file-issue branch December 21, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants