Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation-related changes required for M4.5.7 #568

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

agarny
Copy link
Contributor

@agarny agarny commented Nov 11, 2022

To be merged in ONLY IF datasets 135 and 157 have been revised on Pennsieve before 25 November 2022.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Delete those that don't apply.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

This was tested using yet-to-be-revised datasets (135 and 157).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added unit tests that prove my fix is effective or that my feature works

@alan-wu alan-wu self-requested a review December 19, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant