Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing segmentation viewer metadata #202

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

ddjnw1yu
Copy link
Collaborator

@ddjnw1yu ddjnw1yu commented Sep 15, 2024

This PR is to fix the ticket issue - Missing Thumbnail and Metadata on Segmentation Viewer.

The issue is due to the incorrect file path used to fetch the metadata.

This file path used to fetch viewer metadata is from Pennsieve, which may differ from the one from Scicrunch. The file path in Scicrunch will usually be the correct one. Therefore, replace the path in the file with the Scicrunch file path.

Segmentations in dataset 230:

Screenshot 2024-09-16 at 9 31 58 AM Screenshot 2024-09-16 at 9 31 28 AM

Copy link

cypress bot commented Sep 15, 2024

SPARC Vue3 Portal Testing    Run #251

Run Properties:  status check failed Failed #251  •  git commit b7bca4af4f: Replace the path in file with scicrunch file path
Project SPARC Vue3 Portal Testing
Branch Review segmentation-metadata
Run status status check failed Failed #251
Run duration 18m 10s
Commit git commit b7bca4af4f: Replace the path in file with scicrunch file path
Committer David J. Yu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 69
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/e2e/mapsviewer.cy.js • 2 failed tests

View Output

Test Artifacts
Maps Viewer > Provenance card for Rat Screenshots
Maps Viewer > Provenance card for Human Female Screenshots

@ddjnw1yu
Copy link
Collaborator Author

SPARC Vue3 Portal Testing    Run #251

Run Properties:  <img alt="status check failed" width="10" height="10" src="https://camo.githubusercontent.com/ce191f2ed15e540ea28844862a5b05965953f7fda5ae04d3aa5ec730899a106e/68747470733a2f2f6173736574732e637970726573732e696f2f6769746875622d70722d636f6d6d656e742d69636f6e732f6661696c65642e737667"> Failed [#251](https://cloud.cypress.io/projects/96rtme/runs/251/overview?utm_source=github&utm_medium=failed&utm_campaign=run%20number)  •  <img alt="git commit" width="10" height="10" src="https://camo.githubusercontent.com/0a4d777bd84d33143a9bd3359a9a5b9817b5b1201ffe6da7c3accaa1a0bc88de/68747470733a2f2f6173736574732e637970726573732e696f2f6769746875622d70722d636f6d6d656e742d69636f6e732f6769742d636f6d6d69742e737667"> [b7bca4af4f](https://github.com/nih-sparc/sparc-app-2/commit/b7bca4af4f037631b7af457997d0476a3ed43b94): Replace the path in file with scicrunch file path
Test results
Tests that failed  Failures **2**
Tests that were flaky  Flaky **0**
Tests that did not run due to a developer annotating a test with .skip  Pending **2**
Tests that did not run due to a failure in a mocha hook  Skipped **0**
Tests that passed  Passing **69**
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/e2e/mapsviewer.cy.js • 2 failed tests

Failed tests are not related to the changes.

Copy link
Contributor

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

@alan-wu alan-wu merged commit 03cb209 into nih-sparc:main Sep 19, 2024
0 of 2 checks passed
@ddjnw1yu ddjnw1yu deleted the segmentation-metadata branch September 19, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants