Add missing organization name in fallback #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPARC Vue3 Portal Testing
|
|||||||||||||||||||||||||||||||||||||
| Project |
SPARC Vue3 Portal Testing
|
| Branch Review |
bugfix/dataset-organization
|
| Run status |
|
| Run duration | 17m 36s |
| Commit |
|
| Committer | akhuoa |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
69
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/cypress/e2e/mapsviewer.cy.js • 2 failed tests
| Test | Artifacts | |
|---|---|---|
| Maps Viewer > Provenance card for Rat |
Screenshots
|
|
| Maps Viewer > Provenance card for Human Female |
Screenshots
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dataset 407 has the new organization name,
"organizationName": "NIH PRECISION Human Pain Network", and it is not in thepennsieve.organization.namelist, and also not in the fallback values list ofgetOrganizationNames.When the dataset's organization name is not in the list of
sparcOrganizationNames, it is trying to redirect to DOI link.sparc-app-2/pages/datasets/[datasetId].vue
Line 292 in 0b39105
However, when the DOI link is redirected back to the dataset page, it ends up in an endless loop and throws a 500 error.
This fix is to prevent that error by adding the missing organization name in the fallback.