Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapintegratedvuer to 1.4.2. #200

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

alan-wu
Copy link
Contributor

@alan-wu alan-wu commented Sep 11, 2024

This update fix an issue with the minimap on the flatmapviewer.

A separate hot-fix branch has been created here - https://github.com/nih-sparc/sparc-app-2/tree/v1.3.0_hot-fixes

A heroku instance with Portal v1.3.0 + the viewer update can be found herr - https://alan-wu-sparc-app.herokuapp.com/

Bug:
image

Fixed:
image

Copy link

cypress bot commented Sep 11, 2024

SPARC Vue3 Portal Testing    Run #249

Run Properties:  status check failed Failed #249  •  git commit 4a31be908e: Update mapintegratedvuer to 1.4.2.
Project SPARC Vue3 Portal Testing
Branch Review v1.3.0_hot-fixes
Run status status check failed Failed #249
Run duration 18m 07s
Commit git commit 4a31be908e: Update mapintegratedvuer to 1.4.2.
Committer alan-wu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 69
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/e2e/mapsviewer.cy.js • 2 failed tests

View Output

Test Artifacts
Maps Viewer > Provenance card for Rat Screenshots
Maps Viewer > Provenance card for Human Female Screenshots

@egauzens
Copy link
Collaborator

failing tests are unrelated

@egauzens egauzens merged commit 9776862 into nih-sparc:main Sep 12, 2024
0 of 2 checks passed
@alan-wu alan-wu deleted the v1.3.0_hot-fixes branch November 14, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants