Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker__daemon_json_dict setting #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

waynr
Copy link

@waynr waynr commented Jun 27, 2020

See #93

@nickjj
Copy link
Owner

nickjj commented Jun 28, 2020

I like the idea in general but the implementation would need a number of changes.

There's both a docker__default_daemon_json and docker__daemon_json variable that get merged together so we'd want to use combine() for that. Then there's updating the tests too.

I'm also not a fan of keeping around 2 documented ways to configure the same thing or the name of the variables themselves. Perhaps it could now be docker__daemon_options. If it were named that originally we could have gotten by with having both 1 set of variables and backwards compatibility at the jinja template level (if the var is a string do the old thing else do the new thing) but that ship has sailed.

I think the only real option is to bite the bullet and make a backwards incompatible change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants