docker-moby: enable buildx plugin #30
Conversation
Signed-off-by: Can Wong <[email protected]>
usercw88
force-pushed
the
dev/next/docker_buildx
branch
from
7bbf3b4
to
b7da4ba
Compare
There was a problem hiding this comment.
This is not intended to be submitted to ni/meta-virtualization
The goal is to submit this to meta-virtualization (scarthgap) upstream
Seeing that buildx was an optional plugin, are we sure upstream will accept this change building the plugin by default? If docker can work without buildx, I suspect this change may not be accepted upstream.
| @@ -166,3 +174,7 @@ FILES:${PN}-cli += "${bindir}/docker" | |||
| # NOT rdepend to get a classic one-package install | |||
| DOCKER_UNIFIED_PACKAGE ?= "True" | |||
| RDEPENDS:${PN} += "${@bb.utils.contains("DOCKER_UNIFIED_PACKAGE", "True", "${PN}-cli", "", d)}" | |||
|
|
|||
| PACKAGES =+ "${PACKAGE_NAME}-buildx-plugin" | |||
There was a problem hiding this comment.
${PN} would result in "docker-moby-buildx-plugin"
${PACKAGE_NAME} would result in "docker-buildx-plugin"
According to https://docs.docker.com/engine/install/centos/#installation-methods (referenced in the above comment) the buildx-plugin is not intended to have "moby" or "ce" within it's package name
Not sure if they will allow it, but it's worth a try? |
It's up to you but I'd ask why this should be part of docker.inc and not a separate docker-buildx.bb recipe so that users that don't care about buildx don't get increased build times due to adding buildx to docker.inc. |
|
FYI I'd be ok with just ni/meta-nilrt#767 and call it a day if disabling BUILDX doesn't affect our container tests. |
AB#2939060
Note: This is not intended to be submitted to ni/meta-virtualization
The goal is to submit this to meta-virtualization (scarthgap) upstream
Testing:
[x] Built docker-moby locally and verified the creation of docker-buildx binary, docker-buildx-plugin package
[x] Installed docker-buildx-plugin onto a system and verified creating "BuildKit" containers function correctly