Add SetRuntimeEnvironment call to library constructors #973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add an Library::SetRuntimeEnvironment call upon library load, before init is called.
(Based on #962, but tweaked the template code to be a little cleaner)
Implemented via the following changes:
Why should this Pull Request be merged?
As developers, we want to know how much nigrpc_device_server is used and which versions.
What testing has been done?
TODOs:
We have a separate internal work item for this. The current plan is to templatize the LibraryClasses so that a FakeSharedLibrary class can be used and add a little functionality to the LibraryClass to track whether SetRuntimeEnvironment has been called.