Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for coerced type (read/write API for FPGA) #1134

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amehra-ni
Copy link
Contributor

What does this Pull Request accomplish?

The int32 and int64 implementations are similar as neither of them are coerced. Therefore, I have updated the int32 test to an int16 test to ensure we can test both behaviors.

Why should this Pull Request be merged?

  • For the read API, I updated the read type to int16_t to match what is read from the real API.
  • For the write API, I kept the type as pb::int32 since this is the value passed from the gRPC API to our server and then to native.

What testing has been done?

  • All tests pass successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant