Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add secret type for getAndValidateSecret() #6877

Merged
merged 2 commits into from
Nov 28, 2024
Merged

add secret type for getAndValidateSecret() #6877

merged 2 commits into from
Nov 28, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Nov 27, 2024

Proposed changes

refactor of getAndValidateSecret() in preparation for r33 secrets

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 27, 2024 15:25
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 53.21%. Comparing base (8b8fc52) to head (7c1f9f3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/nginx-ingress/main.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6877      +/-   ##
==========================================
- Coverage   53.24%   53.21%   -0.03%     
==========================================
  Files          88       88              
  Lines       20363    20365       +2     
==========================================
- Hits        10842    10838       -4     
- Misses       9078     9082       +4     
- Partials      443      445       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 merged commit 5b5e052 into main Nov 28, 2024
81 checks passed
@pdabelf5 pdabelf5 deleted the secret-type-check branch November 28, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants