Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go toolchain and NIC version #6859

Merged
merged 3 commits into from
Nov 25, 2024
Merged

update go toolchain and NIC version #6859

merged 3 commits into from
Nov 25, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Nov 25, 2024 •
edited
Loading

Proposed changes

  • fix golang toolchain
  • update NIC version in v5 docs

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners November 25, 2024 13:30
@github-actions github-actions bot added the bug An issue reporting a potential bug label Nov 25, 2024
@vepatel vepatel enabled auto-merge (squash) November 25, 2024 13:31
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6859/

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Nov 25, 2024
@vepatel vepatel changed the title update go toolchaine update go toolchain and NIC version Nov 25, 2024
@vepatel vepatel merged commit 561824f into release-3.7 Nov 25, 2024
24 checks passed
@vepatel vepatel deleted the fix/site-go-toolchain branch November 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @j1m-ryan @pdabelf5