Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename TLSSecretFileMode to ReadWriteOnlyFileMode #6854

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

pdabelf5
Copy link
Collaborator

Proposed changes

Make file mode const generic to re-use for other file types

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 22, 2024 16:14
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 53.25%. Comparing base (6007227) to head (0a1b694).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/configs/configurator.go 0.00% 4 Missing ⚠️
cmd/nginx-ingress/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6854      +/-   ##
==========================================
+ Coverage   53.23%   53.25%   +0.01%     
==========================================
  Files          88       88              
  Lines       20354    20354              
==========================================
+ Hits        10835    10839       +4     
+ Misses       9074     9072       -2     
+ Partials      445      443       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pdabelf5 pdabelf5 merged commit ee602b3 into main Nov 25, 2024
79 checks passed
@pdabelf5 pdabelf5 deleted the file-mode-refactor branch November 25, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants