Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/add events to configmap #6819

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Chore/add events to configmap #6819

merged 6 commits into from
Nov 18, 2024

Conversation

j1m-ryan
Copy link
Member

Proposed changes

Add events to main Nginx Config ConfigMap

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner November 18, 2024 12:38
@github-actions github-actions bot added go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests labels Nov 18, 2024
@j1m-ryan j1m-ryan enabled auto-merge (squash) November 18, 2024 15:58
@j1m-ryan j1m-ryan merged commit 1984678 into main Nov 18, 2024
79 checks passed
@j1m-ryan j1m-ryan deleted the chore/add-events-to-configmap branch November 18, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j1m-ryan @AlexFenlon @jjngx @pdabelf5