Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow k8s events in initial validation #6814

Merged
merged 2 commits into from
Nov 15, 2024
Merged

allow k8s events in initial validation #6814

merged 2 commits into from
Nov 15, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Nov 15, 2024 •
edited
Loading

Proposed changes

Move EventRecorder to main() function to allow Pod events to be generated on pod initialisation.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 15, 2024 11:26
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 15, 2024
@pdabelf5 pdabelf5 merged commit 8703f0e into main Nov 15, 2024
79 checks passed
@pdabelf5 pdabelf5 deleted the recorder-refactor branch November 15, 2024 12:47
AlexFenlon pushed a commit that referenced this pull request Nov 15, 2024
@pdabelf5 @AlexFenlon
allow k8s events in initial validation (#6814)
8aad004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdabelf5 @AlexFenlon @jjngx