Python 2: restrict to macOS. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thresheek
force-pushed
the
python2-only-macos
branch
from
1024b15
to
9d5832b
Compare
Homebrew does not ship python 2, which makes the dependency wrong on Linux as it resolves to current Python 3. Also, we already limit it to an older version of macOS (11 and older), which still ships Python 2. Note that our "weekly" CI builds are using macOS 11 to build this formula.
thresheek
force-pushed
the
python2-only-macos
branch
5 times, most recently
from
0c2e21a
to
0ac8032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homebrew does not ship python 2, which makes the dependency wrong on Linux as it resolves to current Python 3.
Also, we already limit it to an older version of macOS (11 and older), which still ships Python 2.
Note that our "weekly" CI builds are using macOS 11 to build this formula.