-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user search by email #3777
Fix user search by email #3777
Conversation
Signed-off-by: Côme Chilliet <[email protected]>
…earch result Signed-off-by: Côme Chilliet <[email protected]>
Renaming the subname seems to be no problem. |
Just for reference: nextcloud-libraries/nextcloud-vue#6219 |
@dartcafe Can this be merged? Should I ask the bot to "backport" to |
Sure, I approved. 😉 |
@come-nc Ah, no, backport not necessary. I did the backport already manually, just forgot to link that. |
@dartcafe Would you consider releasing 7.2.5 so that this fix makes it to the appstore? |
@come-nc I released 7.2.5 yesterday. |
Searching for users to share with by email was broken.
This is due to 2 problems:
subName
instead ofsubname
@dartcafe Is it safe to rename subName to subname or is used elsewhere? The only instance I could find is https://github.com/nextcloud/polls/blob/master/src/js/store/modules/acl.js#L16 and it looks pretty safe to rename if needed.